Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Parts: Remove forced Spotlight Mode on selection #40646

Closed
jameskoster opened this issue Apr 27, 2022 · 0 comments · Fixed by #40652
Closed

Template Parts: Remove forced Spotlight Mode on selection #40646

jameskoster opened this issue Apr 27, 2022 · 0 comments · Fixed by #40652
Assignees
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@jameskoster
Copy link
Contributor

We've tried a few experiments in the Site Editor to clarify the boundaries of Template Parts. There are currently three hints:

Screenshot 2022-04-27 at 11 34 01

  1. The template part name is displayed in the top bar when it – or any of its child blocks – is selected
  2. The template part is outlined, both on hover (which helps with selection) and on click
  3. Blocks outside the selected template part are semi-transparent, similar to the Editor's 'Spotlight mode'

Three hints is perhaps a bit excessive. I propose we remove the third one for two reasons:

  1. It's easy to add back via user preference – just enable Spotlight mode to achieve a similar result
  2. It's essentially doing the same job as the first hint.
@jameskoster jameskoster added [Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 27, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 27, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants