Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e - file names are too long on windows #40291

Closed
carolinan opened this issue Apr 13, 2022 · 5 comments
Closed

e2e - file names are too long on windows #40291

carolinan opened this issue Apr 13, 2022 · 5 comments
Labels
[Package] E2E Tests /packages/e2e-tests

Comments

@carolinan
Copy link
Contributor

carolinan commented Apr 13, 2022

What problem does this address?

@JustinyAhin I believe this is related to the switch to Playwright. Either way it is a recent issue.
When I try to work with Gutenberg changes and for example stash my local changes, I get errors like these:

PS D:\sites\basicwordpresstest\app\public\wp-content\plugins\gutenberg> git stash
error: lstat("test/e2e/specs/editor/various/copy-cut-paste-whole-blocks.spec.js-snapshots/Copy-cut-paste-of-whole-blocks-should-respect--957b6-opy-in-places-like-input-fields-and-textareas-2-chromium.txt"): Filename too long
fatal: Unable to process path test/e2e/specs/editor/various/copy-cut-paste-whole-blocks.spec.js-snapshots/Copy-cut-paste-of-whole-blocks-should-respect--957b6-opy-in-places-like-input-fields-and-textareas-2-chromium.txt
Cannot save the current worktree state

I have already moved my installation to a shorter path, but it is still too long.
test/e2e/specs/editor/various/copy-cut-paste-whole-blocks.spec.js-snapshots/Copy-cut-paste-of-whole-blocks-should-respect--957b6-opy-in-places-like-input-fields-and-textareas-2-chromium.txt
alone is 189 characters.

What is your proposed solution?

Is it possible to use shorter paths and filenames?

@JustinyAhin
Copy link
Member

JustinyAhin commented Apr 13, 2022

@carolinan oh this is because when we migrate a new test to Playwright, we delete the original one. This error in particular should be related to #39807.

cc @kevin940726

@kevin940726
Copy link
Member

Oh wow, I didn't know that there's a file name limit on Windows. I'll see what I can do.

@kevin940726
Copy link
Member

@kevin940726
Copy link
Member

kevin940726 commented Apr 14, 2022

Opened a PR in #40336, LMK if it solves the problem!

@ndiego ndiego added the [Package] E2E Tests /packages/e2e-tests label Apr 15, 2022
@kevin940726
Copy link
Member

#40336 is merged, I'll close this now but feel free to re-open if it doesn't solve the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] E2E Tests /packages/e2e-tests
Projects
None yet
Development

No branches or pull requests

4 participants