Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previews for custom block styles are not showing in the Site Editor #40064

Closed
carolinan opened this issue Apr 6, 2022 · 3 comments · Fixed by #40245
Closed

Previews for custom block styles are not showing in the Site Editor #40064

carolinan opened this issue Apr 6, 2022 · 3 comments · Fixed by #40245
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

carolinan commented Apr 6, 2022

Description

I apologize if this has already been reported, it was not easy to search for these keywords in the GitHub repository.

In the block editor, if a block has a custom style registered, you can hover over the options in the style section to see a modal/popup with a preview of the style.

But this preview is not present in the Site Editor. Nothing happens when you hover over the style.

And because the style names are truncated, it is difficult to know what the style does.
For example, if I have a button block style called "Button with shadow", the name would have been self explanatory even without a preview: But because the full name is not displaying and instead showing as "Button with...", it is difficult to identify what the style does.

Step-by-step reproduction instructions

  1. Activate a full site editing theme
  2. Open the Site Editor
  3. Add a block with a style, for example an image block or a button block.
  4. In the block setting sidebar, find the "Styles" section
  5. Hover over the different options and see that there is no preview.

Screenshots, screen recording, code snippet

Site Editor:
Animation of mouse hovering over the style setting and no preview showing

Post editor, and expected result:
Animation of mouse hovering over the style setting and preview is showing

Environment info

WordPress 5.9.3 Rc1
Gutenberg current trunk
Beta tester plugin

Please confirm that you have searched existing issues in the repo.

Yes

Please

confirm that you have tested with all plugins deactivated except Gutenberg.

No

@carolinan carolinan added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Apr 6, 2022
@annezazu
Copy link
Contributor

annezazu commented Apr 6, 2022

I can replicate this with! Adding as a bug.

@annezazu annezazu added the [Type] Bug An existing feature does not function as intended label Apr 6, 2022
@ndiego
Copy link
Member

ndiego commented Apr 7, 2022

Yes, I can replicate it as well.

@glendaviesnz glendaviesnz self-assigned this Apr 12, 2022
@glendaviesnz glendaviesnz moved this from Triage to In Progress in WordPress 6.0 Editor Tasks Apr 12, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 12, 2022
Repository owner moved this from In Progress to Done in WordPress 6.0 Editor Tasks Apr 12, 2022
@Andrew-Starr
Copy link

Just want to mention #39944 in case there is any chance it could be related.

Not too sure what components (if any) are shared across site editor and post editor in regard to block style previews.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants