Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: Multi-select follow ups (de-selecting blocks, accessibility wording) #39671

Closed
5 tasks
andrewserong opened this issue Mar 23, 2022 · 4 comments
Closed
5 tasks
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility Needs Dev Ready for, and needs developer efforts

Comments

@andrewserong
Copy link
Contributor

andrewserong commented Mar 23, 2022

Following on from #39272 where multi-select support was added to the List View for shift + Home and End keys, this issue tracks a few items of feedback that didn't make it in the scope of that PR, but would be good to follow-up on and implement.

Issues to follow up on

  • Allow blocks to be de-selected via keyboard. Currently you can hold the shift key down to select blocks with the up and down arrows and the home and end keys, however it's impossible to deselect all blocks via the keyboard. Is there a keyboard shortcut or other mechanism we can add to make it easy to deselect all the blocks?
  • While we're at it, should we add in CMD / CTRL + A to select all blocks?
  • Having the word "link" as part of the label is probably bad practice long term. Can we add description text instead?
Press Enter to jump to block.

We don't want to confuse users by making them think these items are links, we just need to communicate to users that you can select it to jump to a block.

  • Possible to evaluate markup and see if there are any redundant attributes that can be removed?
  • The label text for the highlighted block is confusing when announced via a screen reader. We can update the description in getBlockPositionDescription. Due to using a tree grid, the announcement includes both the block description and the row column of the grid, which can be confusing. For example the following is announced when focusing on a selected paragraph block:
Paragraph  selected  Block 1 of 9, Level 1  row 1  column 1

Before we open up PRs to explore these issues, it would be good to get some feedback from folks on the desired wording and behaviour.

Thanks @alexstine for the suggestions!

@andrewserong andrewserong added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Block Multi Selection The ability to select and manipulate multiple blocks Needs Accessibility Feedback Need input from accessibility [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Mar 23, 2022
@alexstine
Copy link
Contributor

Added a couple suggestions but everything looks good here so far.

@github-actions
Copy link

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label Sep 27, 2022
@alexstine alexstine added Needs Dev Ready for, and needs developer efforts and removed Needs Testing Needs further testing to be confirmed. labels Sep 27, 2022
@andrewserong
Copy link
Contributor Author

I believe most of the work tracked in this issue is now either complete, or in progress and tracked elsewhere, e.g. in #49563.

@alexstine do you mind if I close out this issue, and consolidate follow-ups elsewhere (i.e. in #49563)? Happy to keep it open if you're still using it.

@alexstine
Copy link
Contributor

Sounds good. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

2 participants