Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping a Group block #39062

Closed
richtabor opened this issue Feb 24, 2022 · 0 comments · Fixed by #39094
Closed

Grouping a Group block #39062

richtabor opened this issue Feb 24, 2022 · 0 comments · Fixed by #39094
Assignees
Labels
[Block] Group Affects the Group Block (and row, stack and grid variants) [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

What problem does this address?

Upon building out Twenty Twenty Two, we found that placing group blocks within group blocks is a fundamental part of building out a block theme; particularly with headers/footers/templates. Here's an example of the header in TT2, with group > group blocks.

Today, to put a group block into another group block, one has to add a second group block, then drop the "inner" group block into the new one — as the more streamlined approach of selecting the "Group" option from the block toolbar, or using the "Group" transform, are both omitted from the Group block.

In contrast, grouping any other block is as simple as selecting the "Group" option from the block toolbar vertical ellipsis menu.

What is your proposed solution?

  1. Add the "Group" control above the "Ungroup" control for Group blocks (so that the grouping functionality is the same for Group blocks, as it is for any other block.
  2. Consider adding the "Group" transform to the group block. Transforms are already getting a little shaky with the Group and Columns blocks, as experience-wise transforming to a Group/Columns block is very different than transforming between a Paragraph and a Heading block. But it may still be valuable to build consistently when using the Group block. 3. Aso, the Columns block does allow a transform into another Columns block already.

Current (selecting a group block with an image block inside it):

CleanShot 2022-02-24 at 12 05 52@2x

Proposed (selecting a group block with an image block inside it — now with an additional "Group" control):

CleanShot 2022-02-24 at 12 15 58@2x

@richtabor richtabor added [Block] Group Affects the Group Block (and row, stack and grid variants) [Type] Enhancement A suggestion for improvement. labels Feb 24, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 25, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block (and row, stack and grid variants) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants