Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Save as pending" and "Save draft" button labels duplicated when toolbar UI preference is set to show labels #38773

Closed
nekohayo opened this issue Feb 13, 2022 · 1 comment · Fixed by #38776
Closed

"Save as pending" and "Save draft" button labels duplicated when toolbar UI preference is set to show labels #38773

nekohayo opened this issue Feb 13, 2022 · 1 comment · Fixed by #38776
Assignees
@Mamaduka
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@nekohayo
Copy link

Description

When "Display button labels" is turned on, the toolbar shows "Save as draftSave as draft" or "Save as pendingSave as pending".

Step-by-step reproduction instructions

  1. Go to the post editor
  2. Click the three-dots icon in the top-right, go to Preferences
  3. Turn on "Display button labels"

Screenshots, screen recording, code snippet

Screenshot from 2022-02-13 18-49-36

Environment info

  • Wordpress 5.9 with its built-in Gutenberg version
  • Firefox on Fedora Linux

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@talldan talldan added [Type] Bug An existing feature does not function as intended [a11y] Labelling General Interface Parts of the UI which don't fall neatly under other labels. labels Feb 14, 2022
@Mamaduka
Copy link
Member

It looks like a regression after #34948.

@Mamaduka Mamaduka mentioned this issue Feb 14, 2022
Merged
8 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 14, 2022
@nekohayo nekohayo mentioned this issue Feb 14, 2022
Closed
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Labelling labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid duplicate labels for "Save Draft" and "Save as pending" buttons WordPress/gutenberg
4 participants
@Mamaduka @nekohayo @talldan @priethor