Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut to toggle settings/sidebar's display is not working #38146

Closed
skorasaurus opened this issue Jan 21, 2022 · 3 comments
Closed
Labels
[Package] Keyboard Shortcuts /packages/keyboard-shortcuts [Type] Regression Related to a regression in the latest release

Comments

@skorasaurus
Copy link
Member

skorasaurus commented Jan 21, 2022

Description

The keyboard shortcut to show/hide settings sidebar, done by Ctrl+Shift+, for windows and linux users does not show/hide settings sidebar as expected.

Step-by-step reproduction instructions

  1. create a new post or page
  2. Press Ctrl+Shift+, (press simultaneously the control button, shift, and the comma) ( shortcut and mac directions taken from the FAQ

The sidebar panel displaying a block's settings or the page/post's setting should appear or hide.

Environment info

  • ubuntu 18.04
  • English (US) QWERTY keyboard
  • Chrome and Firefox 86
  • WordPress 5.8.3 and gutenberg 12.4.1.

Krishna Thackur also reported in the #core-editor slack that he has the same behavior using 5.9-RC3-52601

- Notably, the shortcut works as expected for me on WordPress 5.7 with gutenberg plugin deactivated

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@skorasaurus skorasaurus added [Type] Bug An existing feature does not function as intended [Package] Keyboard Shortcuts /packages/keyboard-shortcuts [Type] Regression Related to a regression in the latest release and removed [Type] Bug An existing feature does not function as intended labels Jan 21, 2022
@apeksha10
Copy link

apeksha10 commented Jan 22, 2022

Hi ,
I am able to replicate the above issue in Windows
Steps
Chrome browser
WordPress (5.9-RC3-52617) and Gutenberg 12.4.1.
Click (Press Ctrl+Shift+,)
4. The sidebar panel displaying a block's settings or the page/post's setting doesn't hide.
See the video: https://www.screencast.com/t/Tbtlww8S

@letasync
Copy link

Hi @skorasaurus
Thanks for confirming & reporting.

My test env was
Chrome browser on Window 10
WordPress 5.9-RC3-52601 without gutenberg or any other plugin.
and WordPress 5.8 with gutenberg 12.04 without any other plugin.

@t-hamano
Copy link
Contributor

I would like to close this issue as it has been fixed in #43428. If you still reproduce it, please feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Keyboard Shortcuts /packages/keyboard-shortcuts [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

3 participants