Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE Navigation block: Menu item for "Posts page" is missing required class if added as static page #37657

Closed
them-es opened this issue Dec 30, 2021 · 1 comment
Labels
[Block] Navigation Affects the Navigation Block

Comments

@them-es
Copy link
Contributor

them-es commented Dec 30, 2021

Description

If a posts page has been added as a static page (see instructions/screenshot below) the respective menu item should include required menu classnames like current-menu-item.

Step-by-step reproduction instructions

  1. Open Settings > Reading and select "Your homepage displays a static page"
  2. Select a "Homepage" (e.g. Home) and a "Posts page" (e.g. News)
  3. Install a FSE Theme (e.g. TwentyTwentyTwo)
  4. Edit site and add a new navigation with the custom links "Home" and "News"
  5. Open the frontend and access "News".
  6. The menu item class is missing current-menu-item (Home works as expected!)

Screenshots, screen recording, code snippet

reading

News: Missing "current-menu-item" class
inspector

Home: Ok
inspector-home

Environment info

  • WordPress 5.8.2 (+ Gutenberg 12.2.0) OR WordPress 5.9 (RC 1)
  • TwentyTwentyTwo Theme
  • Chrome/Firefox (latest versions)

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added the [Block] Navigation Affects the Navigation Block label Dec 30, 2021
@them-es them-es changed the title Full Site Editing Navigation: Menu item for "Posts page" is missing required class if added as static page FSE Navigation block: Menu item for "Posts page" is missing required class if added as static page Dec 30, 2021
@them-es
Copy link
Contributor Author

them-es commented Jul 19, 2023

Closing as it seems to be fixed by #51478 (See #34770)

@them-es them-es closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Development

No branches or pull requests

2 participants