Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor History: Site logo block undo and redo issue #37170

Closed
jeyip opened this issue Dec 7, 2021 · 2 comments
Closed

Editor History: Site logo block undo and redo issue #37170

jeyip opened this issue Dec 7, 2021 · 2 comments
Labels
[Block] Site Logo Affects the Site Logo Block [Feature] History History, undo, redo, revisions, autosave. [Type] Bug An existing feature does not function as intended

Comments

@jeyip
Copy link
Contributor

jeyip commented Dec 7, 2021

Description

Undoing and redoing an image block with an uploaded image restores said image. This, however, does not happen for the site logo block. Instead, it restores an empty site logo block.

What's curious is that deleting the site logo block and reintroducing it through the block appender retrieves the previously uploaded site logo without issue.

Step-by-step reproduction instructions

Block Editor

  1. Navigate to the post editor
  2. Add a site logo block
  3. Upload a site logo
  4. Add a paragraph block
  5. Undo until all added blocks are gone
  6. Redo until the paragraph block reappears
  7. Verify that the uploaded site logo does not reappear

Site Editor

  1. Enable full site editing by activating the Gutenberg plugin and an FSE enabled theme (Ex. Quadrat)
  2. Navigate to the site editor
  3. Add a site logo block
  4. Upload a site logo
  5. Add a paragraph block
  6. Undo until all added blocks are gone
  7. Redo until the paragraph block reappears
  8. Verify that the uploaded site logo does not reappear

Screenshots, screen recording, code snippet

Site logo block not working

2021-12-06 16 49 31

Image block working
2021-12-06 16 59 28

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jeyip jeyip added [Type] Bug An existing feature does not function as intended [Feature] History History, undo, redo, revisions, autosave. labels Dec 7, 2021
@jeyip jeyip self-assigned this Dec 7, 2021
@jeyip jeyip added the [Block] Site Logo Affects the Site Logo Block label Dec 7, 2021
@jeyip jeyip removed their assignment Dec 7, 2021
@ndiego ndiego added the Needs Testing Needs further testing to be confirmed. label Mar 21, 2023
@ndiego
Copy link
Member

ndiego commented Mar 21, 2023

I just tested with WordPress 6.2 RC2, and this issue remains.

@ndiego ndiego removed the Needs Testing Needs further testing to be confirmed. label Mar 21, 2023
@Mamaduka
Copy link
Member

It was fixed by #50911.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block [Feature] History History, undo, redo, revisions, autosave. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants