Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus loss when publishing / updating #3689

Closed
afercia opened this issue Nov 28, 2017 · 2 comments
Closed

Focus loss when publishing / updating #3689

afercia opened this issue Nov 28, 2017 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Nov 28, 2017

See #3682

When using a keyboard, publishing or updating a post causes a focus loss. To reproduce:

  • create a new post
  • use your keyboard
  • add some title, add some text in a paragraph
  • tab backwards to reach the Publish button
  • press Enter to open the Publish popover
  • tab to reach the second Publish button and press Enter to publish

At this point, the popover disappears and since it contained the element that was focused, focus is lost. Tab again and you will see you're forced to start keyboard navigation from the document root.

As mentioned several times, focus losses like this one are one of the worst experiences for keyboard users and should be avoided at all costs.
In this case, focus should be managed programmatically and be moved to a place that makes sense in the editing workflow.

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended labels Nov 28, 2017
@mtias
Copy link
Member

mtias commented Nov 28, 2017

Also related to proposed changes in #3496

@noisysocks
Copy link
Member

noisysocks commented Nov 30, 2017

It looks like this was fixed in 1.8.1 (likely by #3717). Now, after I follow these steps, my focus is on the Update button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants