Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to wrap into multiple lines is really confusing #36699

Open
mtias opened this issue Nov 21, 2021 · 3 comments
Open

Allow to wrap into multiple lines is really confusing #36699

mtias opened this issue Nov 21, 2021 · 3 comments
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented Nov 21, 2021

The "allow to wrap into multiple lines" in the navigation block is really confusing and doesn't seem to work in most situations because it has no visible effect.

image

In the short term, let's remove the UI for this feature. In the longer term, we should aim to expose it only when it does make sense (maybe when there are many items).

Generally, this is a setting that most users would have no clue what to do with.

cc @kjellr

@mtias mtias added Needs Design Feedback Needs general design feedback. [Block] Navigation Affects the Navigation Block labels Nov 21, 2021
@pablohoneyhoney
Copy link

I'd advocate for showing it contextually only if the user inputs multiple nav instances.

And even then, recommend explicitly to use below 7 nav links (somewhat of a standard) at the higher nav level, an opportunity also to teach them how to use submenus.

@mtias
Copy link
Member Author

mtias commented Nov 22, 2021

For the case of the collapsed menu it also seems we can establish some defaults that "just work". When the menu collapses, it should remain on the same line, when the menu is expanded we should probably just fall into the next line.

@kjellr
Copy link
Contributor

kjellr commented Nov 22, 2021

I think it's totally fine to remove this from the UI. We ran into some issues working with it for TT2. In short, we found that it is very useful in some cases, but does some harm in others. It's helpful to have, but not essential to show for most users.

@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

3 participants