Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color palette: Design updates #36543

Closed
9 of 10 tasks
Tracked by #35093
kellychoffman opened this issue Nov 16, 2021 · 6 comments
Closed
9 of 10 tasks
Tracked by #35093

Color palette: Design updates #36543

kellychoffman opened this issue Nov 16, 2021 · 6 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Dev Ready for, and needs developer efforts [Priority] High Used to indicate top priority items that need quick attention

Comments

@kellychoffman
Copy link
Contributor

kellychoffman commented Nov 16, 2021

Suggested improvements for 5.9

PR for this started here: #36243

@kellychoffman
Copy link
Contributor Author

Reference image for when there is no color palettes:

image

@mtias
Copy link
Member

mtias commented Nov 16, 2021

And the target design reference:

image

@mtias mtias added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Nov 16, 2021
@priethor priethor added [Priority] High Used to indicate top priority items that need quick attention Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Nov 17, 2021
@priethor priethor changed the title Color palatte: Design updates Color palette: Design updates Nov 17, 2021
@skorasaurus skorasaurus added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Nov 18, 2021
@oandregal
Copy link
Member

oandregal commented Nov 19, 2021

#36622 fixed Never show “core” to a user, use “default” instead and Palettes should be reordered by theme, default, user.

Note that the mockups use "Custom" instead of "User" so I did that as well.

@oandregal
Copy link
Member

#36684 to address the CTA for when there's no colors has been merged.

@oandregal
Copy link
Member

oandregal commented Nov 23, 2021

Added a few tasks that I've seen missing from the mockups or that folks suggested upon reviewing this component:

  • The counter should count all the colors (default, theme, custom) and not only custom.
  • Show gradients and allow to edit them.
  • Show duotones (not editable yet).
  • Call them "palettes" not "color palettes".

@mtias
Copy link
Member

mtias commented Dec 2, 2021

@noisysocks I'm marking this as done as all the important items are covered. The rest button is not a must have and will be part of general improvements to the color panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Dev Ready for, and needs developer efforts [Priority] High Used to indicate top priority items that need quick attention
Projects
None yet
Development

No branches or pull requests

5 participants