-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: assess Heading
styles in the context of the recent design updates
#35464
Comments
@mtias and @jasmussen , do you have any insights on this? |
In exploring the sidebar/inspector/global styles design that is being finalized in #34574, it seems clear that the uppercase styling is used both for input labels and for some subheadings, so it appears to be more of a style than a component, perhaps somewhat comparable to how we have a help-text style (which is 12px font size, default font weight, default text case). CC: @pablohoneyhoney in case he has nuance to add. |
Are you suggesting we introduce variants to the In general, I think that if we want the
Another example of where a heading is required (but doesn't match necessarily the "heading" styles) is |
I'm not necessarily suggesting anything in specific here, only providing context to help a path forward. It's possible that it could exist purely as a heading level style (such as the H3 style), but I do suspect that there might be contexts where the subheading style needs a higher heading level, but still the visually lower styling (such as when showing the contents of a particular panel in a popover opened by the block toolbar). |
Absolutely, I think we should definitely be able to decouple the HTML semantic (e.g. |
I also think we want to end up with very few styles overall, so as to find a good balance, and obvious implied usage guidelines. |
Another example where updated Heading styles would have turned useful (thank @jasmussen) #35568 (comment) |
A few more examples:
|
See also the |
As originally discussed in #35400 (comment), it looks like the
Heading
component may currently not fit the needs of the most recent designs (specifically for the Global Styles sidebar, in this case)We should assess the situation and, if necessary, decide how to proceed in order to have a component offering the new heading styles needed for the Global Styles sidebar UI.
Examples that came up recently:
Useful links:
The text was updated successfully, but these errors were encountered: