-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToggleGroupControl: Visual state of an undefined value is inconsistent #35383
Comments
Hey there, can I work on this issue? |
@sRahul-00 Sure thing, thank you! I'll add that I probably think the correct visual state for undefined should be the initial, white one, instead of the black with grayed out text. Would you agree? |
Yeah man!! Totally agreed... |
Hey @sRahul-00 👋 - thanks for your interest for this issue! Really appreciate it!! This fix will be needed for the next WP version 5.9 and is a bit of time sensitive. Would it be possible to work on this soon? I'm happy to help and guide you with whatever you need 😄
Yes, the backdrop should be removed when the selected value doesn't exist as an option. |
Yeah, sure. I'm new to this Open Source World, so I will be thrilled to work upon new opportunities. |
Hey @sRahul-00 👋 - that's great! So did you try anything for the issue? Will you pick it up? |
I'm really sorry. I couldn't a thing as I was really busy due to the construction going in my home. I'm really sorry again. |
No worries at all! Do you want me to pick it up and find yourself another good first issue? I'd be happy to help either way - you can ping me in the |
yeah sure!! But after you're done, I request you to tell me how did you fix it. It'd be really helpful for beginner like me. Best of Luck btw |
Description
The visual state of an initial undefined
value
is different from when the value is set back to undefined after being set to a defined value.Step-by-step reproduction instructions
ToggleGroupControl
withvalue
initially undefined.button
with anonClick
to set thevalue
to undefined.https://codesandbox.io/s/togglegroupcontrol-undefined-state-h8z9q?file=/src/App.js
Screenshots, screen recording, code snippet
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: