-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Logo: update placeholder to wireframe #35096
Comments
Nice! Can we try on that first version with the same drawing we use for the icon but larger so it coincides with the outline? We'd need to redraw it. We should also see how it looks when the style is set to squared. |
Yes, that's what I had in mind. We don't need to do a 1.5 stroke for there. The dotted one could work as well, I think we can try either. |
Lovely. Any could work! Perhaps the tooltip is too long with too many instructions? And do we need two commas? Would a simple |
Cool, let's try the decorative version with a minimal tooltip and go from there. Thanks! |
As a heads up @jasmussen I was playing around a bit and I think we'll need a different SVG asset for the wireframe. If we don't have a fixed size in mind, we can use the vector-effect="non-scaling-stroke" to not distort the stroke size. However siteLogo's path is drawn in a way that it creates a fill, so when a fill is not set the stroke appears to be quite thick. Changes here might be as simple as decomposing this to a circle and a line or path element.
|
I've started work on a PR that's mostly a proof of concept in #35397. It's promising and the remaining todos are fixable, but I'd love to pair with someone on the remaining bits. |
Let's update the site logo placeholder to a wireframe (or similar) with a droppable area. The upload button for the media library should be visible on the toolbar.
The idea here is to make it easier to visualize what a site logo may look like. This is especially helpful when using a site-logo in a pattern when the site logo isn't set yet.
The text was updated successfully, but these errors were encountered: