Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo: update placeholder to wireframe #35096

Closed
Tracked by #30406
gwwar opened this issue Sep 23, 2021 · 10 comments · Fixed by #35397
Closed
Tracked by #30406

Site Logo: update placeholder to wireframe #35096

gwwar opened this issue Sep 23, 2021 · 10 comments · Fixed by #35397
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@gwwar
Copy link
Contributor

gwwar commented Sep 23, 2021

Let's update the site logo placeholder to a wireframe (or similar) with a droppable area. The upload button for the media library should be visible on the toolbar.

The idea here is to make it easier to visualize what a site logo may look like. This is especially helpful when using a site-logo in a pattern when the site logo isn't set yet.

Current Placeholder
CleanShot 2021-09-23 at 10 53 49@2x
An example ideal pattern to display
134512745-2d8607f2-2b6f-48ce-a872-0c5fe1c28f37
@gwwar gwwar added [Type] Enhancement A suggestion for improvement. [Block] Site Logo Affects the Site Logo Block labels Sep 23, 2021
@jasmussen
Copy link
Contributor

Here's an idea for the site logo placeholder:
Site Logo Placeholder Options

@mtias
Copy link
Member

mtias commented Sep 24, 2021

Nice! Can we try on that first version with the same drawing we use for the icon but larger so it coincides with the outline? We'd need to redraw it. We should also see how it looks when the style is set to squared.

@jasmussen
Copy link
Contributor

Can we try on that first version with the same drawing we use for the icon but larger so it coincides with the outline?

Do you mean like this?

circle

If we can get the vectors just right, it could work, even as square:
square

One of the things I like about the icon, though, is the 1.5px stroke, which feels like it departs a little bit from the placeholder material into illustration territory:

1point5

Here's a square version of the dashed line plus icon, just for completeness sake:

square org

@jasmussen
Copy link
Contributor

This one doesn't work, but to cauterize the idea:
Site Logo Placeholder Options

@mtias
Copy link
Member

mtias commented Sep 24, 2021

Yes, that's what I had in mind. We don't need to do a 1.5 stroke for there. The dotted one could work as well, I think we can try either.

@pablohoneyhoney
Copy link

Lovely. Any could work! Perhaps the tooltip is too long with too many instructions? And do we need two commas? Would a simple Add a site logo work reinforced with the upload icon and the state change?

@jasmussen
Copy link
Contributor

Cool, let's try the decorative version with a minimal tooltip and go from there. Thanks!

@gwwar
Copy link
Contributor Author

gwwar commented Sep 27, 2021

As a heads up @jasmussen I was playing around a bit and I think we'll need a different SVG asset for the wireframe. If we don't have a fixed size in mind, we can use the vector-effect="non-scaling-stroke" to not distort the stroke size. However siteLogo's path is drawn in a way that it creates a fill, so when a fill is not set the stroke appears to be quite thick.

Changes here might be as simple as decomposing this to a circle and a line or path element.

With Fill Without Fill
CleanShot 2021-09-27 at 15 53 56@2x CleanShot 2021-09-27 at 15 53 41@2x

@jasmussen
Copy link
Contributor

Nice, non-scaling-stroke looks great, let's definitely explore that one.

I imagine since we'll need to accommodate various border radii, we'll want to combine the horizontal mountain silhouette as an SVG stroke, with a border. Here's an SVG you can use:
Screenshot 2021-09-28 at 09 56 44

<svg width="60" height="60" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="m61 32.622-13.555-9.137-15.888 9.859a5 5 0 0 1-5.386-.073l-9.095-5.989L1 37.5" stroke="#1E1E1E" stroke-linejoin="round" />
</svg>

Some of those vectors might need some tweaking, which are probably best done in context.

@mtias mtias added [Type] Task Issues or PRs that have been broken down into an individual action to take and removed [Type] Enhancement A suggestion for improvement. labels Oct 4, 2021
@jasmussen
Copy link
Contributor

I've started work on a PR that's mostly a proof of concept in #35397. It's promising and the remaining todos are fixable, but I'd love to pair with someone on the remaining bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants