Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Class Names: Add button to choose from block styles #33934

Closed
shaunandrews opened this issue Aug 6, 2021 · 5 comments
Closed

CSS Class Names: Add button to choose from block styles #33934

shaunandrews opened this issue Aug 6, 2021 · 5 comments
Assignees
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Theme Style Variations Related to style variations provided by block themes Needs Design Feedback Needs general design feedback.

Comments

@shaunandrews
Copy link
Contributor

When switching between block styles, the "Additional CSS class(es)" input within the Advanced accordion of the sidebar also updates to reflect the new style.

Current Styles and CSS

It might be nice to connect these two UI's a little, and offer a way to choose from the defined block styles from the Advanced section.

CSS Class name menu

@shaunandrews shaunandrews added Needs Design Feedback Needs general design feedback. [Feature] Theme Style Variations Related to style variations provided by block themes CSS Styling Related to editor and front end styles, CSS-specific issues. labels Aug 6, 2021
@kjellr
Copy link
Contributor

kjellr commented Aug 6, 2021

I'm not totally sure this extra feature is necessary, but if we were to add it, I think the mockups would benefit from some sort of header/title/prepended label inside of the dropdown to be clear that the options there are Styles.

@mtias
Copy link
Member

mtias commented Aug 30, 2021

This would play well with the ability to register your own user styles once we get there.

@ramonjd
Copy link
Member

ramonjd commented Sep 3, 2021

I've made a first, and very rough, pass at this. The list won't show for blocks with no styles.

Sep-03-2021 15-20-32

I'm not also convinced it's necessary, but one argument for the feature would be that the editing styles class value is already connected to the styles controls.

Sep-03-2021 15-25-56

So if you happen to clear the CSS style names manually, and your mouse is loitering about that place anyhow, then it's easier to restore and preview the alternative style options.

@kjellr
Copy link
Contributor

kjellr commented Sep 3, 2021

I'm not also convinced it's necessary, but one argument for the feature would be that the editing styles class value is already connected to the styles controls.

Yeah, that's a good point. Seems like a good reason to give this a try at least.

@apeatling apeatling moved this to ⏱ Not Started in Design Tools Project Jan 13, 2022
@apeatling apeatling moved this from ⏱ Not Started to ⏳ In Progress in Design Tools Project Jan 13, 2022
@ramonjd
Copy link
Member

ramonjd commented Jan 19, 2022

Closing for now until we can revisit the approach.

I've closed the attached PR, which explored a few avenues but ultimately couldn't achieve the desired design 1:1.

We can always reopen if folks think this feature is required and we can use what we've learned.

Thanks to everyone for their help on this one!

@ramonjd ramonjd closed this as completed Jan 19, 2022
Repository owner moved this from ⏳ In Progress to ✅ Done in Design Tools Project Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Theme Style Variations Related to style variations provided by block themes Needs Design Feedback Needs general design feedback.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants