Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging multiple images into an image block does not convert it to a gallery #3364

Closed
hedgefield opened this issue Nov 7, 2017 · 5 comments · Fixed by #4148
Closed

Dragging multiple images into an image block does not convert it to a gallery #3364

hedgefield opened this issue Nov 7, 2017 · 5 comments · Fixed by #4148
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media

Comments

@hedgefield
Copy link

hedgefield commented Nov 7, 2017

Expected Behavior

That dragging a bunch of images into an image block would convert it to a gallery block (or at least multiple image blocks).

Current Behavior

It adds each image in one by one, replacing the previous one and cutting back and forth in an unclear order.

Gutenberg 1.6.1 + WP 4.8.3 vagrant + chrome.

multiupload

@youknowriad
Copy link
Contributor

Dragging multiple images to the editor canvas should create galleries (that's doable using files transform in the Gallery block).

This could be enough if we disable the droppable zone on image blocks when you drag multiple images.

@hedgefield
Copy link
Author

hedgefield commented Nov 7, 2017

That currently also does not work in 1.6.1 🙃 Or were you saying that that should be how it works?

@youknowriad
Copy link
Contributor

Yes, It does not work yet, I was suggesting it as a way to fix this issue.

@karmatosed
Copy link
Member

I agree this would be a good behaviour. My only concern is maybe there is a use case where someone would want separate images. We are making an assumption they want a gallery even when selected image.

@karmatosed karmatosed added [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media labels Nov 8, 2017
@hedgefield
Copy link
Author

hedgefield commented Nov 8, 2017

I agree, that one is tricky. What we could try is showing a choice when you do that, like when a block gets locked and you have choices for overwriting or editing as html etc? Instead it would say 'were you trying to make a gallery or separate images?' Though in general I think it wouldn't be surprising that when you only have one image block and you drag in multiple images, that that would create a gallery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants