Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Posts and Latest Comments blocks don't look great when editor styles are disabled #32718

Closed
noisysocks opened this issue Jun 16, 2021 · 5 comments
Assignees
Labels
[Block] Latest Comments Affects the Latest Comments Block [Block] Latest Posts Affects the Latest Posts Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

Description

With "Use theme styles" turned off, the Latest Posts and Latest Comments blocks don't look great.

Step-by-step reproduction instructions

  1. Go to Posts → Add New.
  2. Go to Preferences → Appearance and turn off "Use theme styles".
  3. Insert a Latest Posts and Latest Comments block.
  4. Select the Latest Comments block and turn off "Display avatar", "Display date", and "Display excerpt".

Expected behaviour

I would expect both blocks to appear as regular unstyled unordered lists, like so.

Screen Shot 2021-06-16 at 14 01 32

Actual behaviour

They don't look like lists.

Screen Shot 2021-06-16 at 13 59 58

@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Block] Latest Posts Affects the Latest Posts Block [Block] Latest Comments Affects the Latest Comments Block labels Jun 16, 2021
@draganescu
Copy link
Contributor

There is a long standing problem with styling the list item in the Customizer: it is missing its bullets:

Screen Shot 2021-06-17 at 09 13 58

@kevin940726
Copy link
Member

It seems to be explicitly added in #14627. Not sure about the design decisions there though 🤔, maybe @getdave has some thoughts?

@getdave
Copy link
Contributor

getdave commented Jun 18, 2021

Gosh that was a long time ago. My brain seems to suggest we removed it because when you add the Latest Posts Block to the main content you didn't want bullet points for each entry in the list, especially if you had the full excerpt and content turned on.

That said it does seem like perhaps that should have been behind a guard to only happen if there is except and content being shown in the list.

I'd suggest perhaps the block shouldn't provide these styles and instead should have an option "show bullet points" which determines whether or not we add/remove the bullets.

@getdave
Copy link
Contributor

getdave commented Jun 18, 2021

I've spun up #32806 as a PoC to see if we want to take this approach.

@noisysocks
Copy link
Member Author

Closing as fixed by #32983.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Comments Affects the Latest Comments Block [Block] Latest Posts Affects the Latest Posts Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants