Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Publicize missing from side panels #3264

Closed
dartiss opened this issue Oct 31, 2017 · 14 comments
Closed

Jetpack Publicize missing from side panels #3264

dartiss opened this issue Oct 31, 2017 · 14 comments
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Meta Boxes A draggable box shown on the post editing screen [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@dartiss
Copy link

dartiss commented Oct 31, 2017

I have the Jetpack Publicize feature switched on but, at the moment, when editing a post with Guternberg, I don't have meta boxes available to me to edit this information - I end up resorting to switching to the standard editing mode just to set this up before publishing (I rarely publish without changing the publicize text).

With most of my other meta boxes now picked up in the latest Gutenberg releases, I was surprised to find this one missing, particularly as it's a Jetpack addition.

I'm running WordPress 4.8.2, Gutenberg 1.5.2.

@aduth
Copy link
Member

aduth commented Nov 1, 2017

Related: #1352 (Possible duplicate)

@dartiss
Copy link
Author

dartiss commented Nov 2, 2017

Yeah, Publicize isn't specifically mentioned there as it's just a more general idea of how the screen should be configured. With the recent Gutenberg releases third party meta boxes, etc, have all appeared but Publicize is noticeably absent - I suspect it's because any changes to the primary meta box (the one in the standard editor with the publishing options in) have not yet been picked up in the new layout.

@BE-Webdesign BE-Webdesign added the [Feature] Meta Boxes A draggable box shown on the post editing screen label Nov 2, 2017
@BE-Webdesign
Copy link
Contributor

Thank you for the report, this should be fixable.

@mtias mtias added the [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. label Jan 4, 2018
@danielbachhuber
Copy link
Member

danielbachhuber commented Jan 23, 2018

Related Automattic/jetpack#7766
Related #4151

@gziolo gziolo added the [Feature] Extensibility The ability to extend blocks or the editing experience label Mar 9, 2018
@c-shultz
Copy link

c-shultz commented Mar 12, 2018

This is primarily a Jetpack/Publicize issue. I suggest closing #3264 in favor of this newly created issue in the Jetpack repo: Automattic/jetpack#9039

@gziolo
Copy link
Member

gziolo commented Mar 13, 2018

@c-shultz, it looks like the plan includes making pre and pot-publish screen extensible so it makes sense to keep this issue open to discuss technical details required on the Gutenberg side to make it done.

Leaving some related PRs for reference:

There are plenty of options how this can be fone for the publish flow. We need to investigate what we need first and pick one of the solutions. Let me know what you think.

@c-shultz
Copy link

Many thanks, @gziolo, for putting this list together! I'm going to nail the design approach down a little more with @MichaelArestad and then I'll get back to you on these.

@c-shultz
Copy link

c-shultz commented Mar 16, 2018

@gziolo, I'm going to pursue making this work in the post-publish view. That's the most desired path for this based on the design mock-ups and discussion. There's a couple challenges to making that work (I'll make another post about that). If any of that falls through, putting this in pre-publish will be a good fallback.

For post-publish, #3321 that you mentioned looks like it would be close to what we need. I see that you closed that in favor of another approach? I wasn't clear on what that approach was. Let me know what you need from me.

Do you plan to develop the Gutenberg side to expose the right hooks? I'm up for learning whatever to get this done (just trying to get a feel for where it makes sense for my responsibility to fit in).

@c-shultz
Copy link

c-shultz commented Mar 16, 2018

There's another potential Gutenberg change that I described in a recent post in Automattic/jetpack#9039. The crux of it is that, for the post-publish flow, I need Publicize to know that a published post is coming from Gutenberg (as opposed to the Classic Editor, API, etc.).

My current solution proposal is to route the publish action from Gutenberg through the Publicize plugin. I would like to create a REST endpoint in Publicize to handle publishing and extend Gutenberg such that posts are submitted to that endpoint. Do you think this is a feasible approach?

Scratch that. Based on feedback in Automattic/jetpack#9039, I'm going to look into calling an endpoint to write a meta key just before Gutenberg publishes.

My plan is to have a pretty solid first iteration on the Jetpack/Publicize backend after this weekend, and then work on the Gutenberg integration over next weekend. I'll plan on working to implement the necessary hooks to make this happen (I'll use #3321 as a rough guide to get started).

@gziolo
Copy link
Member

gziolo commented Mar 21, 2018

Sharing an update. There was new API introduced for Plugins which seems to be the preferred way to add all UI based extensions. See: https://github.com/WordPress/gutenberg/blob/master/plugins/README.md#plugins-api. I would recommend checking it and explore if it could be also used for the post-publish screen.

It could look something like:

const { PluginPostPublish } = wp.editPost.__experimental;
const { registerPlugin } = wp.plugins;

const Component = () => (
	<PluginPostPublish name="publicize" title="Publicize">
		Content of the publicize
	</PluginPostPublish>
);

registerPlugin( 'jetpack', {
	render: Component,
} );

I have no idea what you really need so I simply updated the existing example to give you a better idea what I'm talking about.

@c-shultz
Copy link

Thanks, @gziolo! I'll explore this over the weekend. I don't yet see any reason that this wouldn't work for what I need.

@gziolo
Copy link
Member

gziolo commented May 22, 2018

It is now possible to implement with API introduced in #6798.

@boblmartens
Copy link

Any news on this?

@jbusuttil
Copy link

jbusuttil commented Oct 3, 2018

The original bug report was that the publicize controls from the Classic editor were absent from Gutenberg, notably the ability to edit the text of what would be published to connected social media accounts.

The bug has been marked 'done' because the API now permits the missing features to be added.

However, the original intent of the bug report has been lost as the publicize features remain absent from Gutenberg.

Can this report be reopened, or a new one filed to restore the missing publicize features, please?

Edit: I've opened #10311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Meta Boxes A draggable box shown on the post editing screen [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Development

No branches or pull requests

9 participants