Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text: Add minimum height setting #31811

Open
alaczek opened this issue May 14, 2021 · 3 comments · May be fixed by #32325
Open

Media & Text: Add minimum height setting #31811

alaczek opened this issue May 14, 2021 · 3 comments · May be fixed by #32325
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Enhancement A suggestion for improvement.

Comments

@alaczek
Copy link

alaczek commented May 14, 2021

Would it be possible to add a minimum height setting to Media & Text block (same as in Cover block)? This would be useful for creating single-page business-card type websites like this one:

image

While it is possible to do this now by nesting the Cover block inside Media & Text, it unnecessarily complicates the code.

Related to #28506

@Mamaduka Mamaduka added [Block] Media & Text Affects the Media & Text Block [Type] Enhancement A suggestion for improvement. labels May 14, 2021
@kjellr
Copy link
Contributor

kjellr commented May 14, 2021

I'd like to +1 this issue — having this control available here would make a lot of pattern designs much simpler to build.

@devfle
Copy link
Contributor

devfle commented May 18, 2021

Hi, I think the idea is great and I will try to implement it. :)

@devfle
Copy link
Contributor

devfle commented May 26, 2021

Short update: I'm almost done. I still need to do the migration (deprecated.js). Then I'll put the PR. I think I will be done with it in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants