Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacer block can only be expanded horizontally in navigation block submenus #30590

Closed
talldan opened this issue Apr 8, 2021 · 2 comments
Closed
Labels
[Block] Navigation Affects the Navigation Block [Block] Spacer Affects the Spacer Block [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Apr 8, 2021

Description

The spacer block can only be expanded horizontally in navigation block submenus. It seems like it should instead work vertically—the same orientation as a submenu.

Step-by-step reproduction instructions

  1. Add a navigation block (horizontal)
  2. Add a link and create a submenu with some more links
  3. Try adding a spacer to a submenu

Expected behaviour

The spacer can be used to space out links in the submenus

Actual behaviour

The spacer can only be used to make the submenu wider

Screenshots or screen recording (optional)

spacer-submenu

@talldan talldan added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block [Block] Spacer Affects the Spacer Block labels Apr 8, 2021
@annezazu
Copy link
Contributor

annezazu commented Feb 7, 2022

Seeing as the spacer block isn't included in blocks allowed for the navigation block after the ligher navigation work #34041, does this issue still make sense to leave open?

@talldan
Copy link
Contributor Author

talldan commented Feb 7, 2022

It's a long story!

Spacer can still be added to the nav block, it has to be added via the Global Inserter like other non-link blocks. It can't be used in submenus anymore by the looks of it, but it can still be used at the root of the nav block in a vertical layout.

It looks like the issue is fixed though since #36340. So I'll close this.

It's worth mentioning that the row block still has the same bug, you can't space items you can just make the row taller. That's described in #36197, so it still seems valid to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Spacer Affects the Spacer Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants