Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block refactor: image link is lost when crop is applied #29996

Closed
glendaviesnz opened this issue Mar 18, 2021 · 3 comments
Closed

Gallery block refactor: image link is lost when crop is applied #29996

glendaviesnz opened this issue Mar 18, 2021 · 3 comments
Assignees
@glendaviesnz
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Mar 18, 2021 •
edited
Loading

Description

If an Image block nested in the refactored gallery block has a link applied and then is cropped the link is lost and needs to be re-added, but the user gets no indication that the link has been removed.

Step-by-step reproduction instructions

  • Check out Gallery refactor PR and enable refactored gallery experiment
  • Add an Image block
  • Add a link to the Image, either custom or Media/Attachment
  • Use the Image toolbar to crop the image and apply change
  • Check link and notice it is gone

Expected behaviour

The link should be copied to the new image

Actual behaviour

Link is removed without any indication/warning that this has happened.

Screenshots or screen recording (optional)

link-gone

WordPress information

  • Gutenberg version: 10.1.1
@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Mar 18, 2021
@Quintis1212
Copy link
Contributor

Quintis1212 commented Mar 19, 2021 •
edited
Loading

Hello @glendaviesnz ) I can not reproduce this bug , can you share more details ?

@glendaviesnz glendaviesnz changed the title Image block: image link is lost when crop is applied Gallery block refactor: image link is lost when crop is applied Mar 22, 2021
@glendaviesnz glendaviesnz added [Block] Gallery Affects the Gallery Block - used to display groups of images and removed [Block] Image Affects the Image Block labels Mar 22, 2021
@glendaviesnz
Copy link
Contributor Author

Hello @glendaviesnz ) I can not reproduce this bug , can you share more details ?

Thanks for testing, looks like it is only happening if the Image is nested in the refactored gallery block - have updated the issued to indicate this.

@glendaviesnz glendaviesnz mentioned this issue Apr 7, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 7, 2021
@glendaviesnz
Copy link
Contributor Author

Fixed by #30550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glendaviesnz glendaviesnz

Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glendaviesnz @Quintis1212