-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: Differences between editor and frontend #29976
Comments
What's the problem for the buttons block (aside the margins between the blocks which are a separate thing cross blocks) |
That's all :) |
@scruffian Do you think we can add a TODO list to the issue description to help clarify what's done, what's remaining... |
Done! I added another one I found for background colors... |
@scruffian do you know we can clarify what is different for each block like:
Sorry if I'm asking too much 😬 It's something you know right away cause you did the screenshot but it might not be obvious by just looking at the screenshots. |
I suppose you did these with Empty theme, right? I just wanted to point out that even though empty theme doesn't add css, it does include some custom supports and as we've found, removing things like |
I added some details about the differences between the blocks under each screenshot. |
Yes, I did these tests with block styles enabled ( These styles should not be loading in the editor unless the theme opts in since #29252 merged. |
I added some more differences which I found when they block styles are disabled. |
@scruffian I haven't been able to reproduce the "Cover" block issue above, any example markup? |
I couldn't reproduce myself, and I think he was using the content from https://theamdemo.wordpress.com/2019/06/24/gutenberg-cover/ I can give you access to it |
This seems to happen when using a background color that isn't defined, e.g.
|
For the drop cap, for me, it's the same between frontend and backend, you can compare properly by having a long text in the paragraph to wrap the drop cap cause otherwise the difference you'll have is related to the margins (which is a cross block issue I'm leaving for its own issue as it's kind of big) |
The Post Title block seems to be in the same size for me (default heading sizes) |
Tables also look the same for me, I do see borders on the frontend. |
I have a PR for the buttons block but I wasn't able to reproduce the center aligned one. |
I guess the group block difference above is about the "padding" in the site editor right? If that's the case, I'll leave that separate because this padding has some wider implications |
Checking in. |
All of these issues were fixed I think we can close this. |
Was there a common theme among the fixes to all these issues? I'm having the same problem with a custom block created with ACF Pro, and I've no idea where to start looking. |
@scott8035, it will really depend on the block. Ideally you want the markup to be the same in the editor and on the frontend, and then also to use the same CSS in both places. |
Latest Comments:
Archives:
File block:
Search block:
Cover block:
Quotation:
When the block styles are disabled:
Paragraph:
Columns:
Post Title:
Opting out of block styles:
Table:
Buttons:
Group:
Embed:
Separator:
There is also a difference in margins for all blocks
TODO:
The text was updated successfully, but these errors were encountered: