-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update post content icon, unuse justify. #29867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Package] Icons
/packages/icons
[Block] Post Content
Affects the Post Content Block
[Block] Comments
Affects the Comments Block - formerly known as Comments Query Loop
labels
Mar 15, 2021
Size Change: +2 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Mar 15, 2021
Thank you for the review ❤️ |
This was referenced Mar 16, 2021
gziolo
added
[Block] Comments (legacy)
The legacy mode of the Comments block (formerly known as Post Comments)
and removed
[Block] Comments
Affects the Comments Block - formerly known as Comments Query Loop
labels
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Comments (legacy)
The legacy mode of the Comments block (formerly known as Post Comments)
[Block] Post Content
Affects the Post Content Block
[Package] Icons
/packages/icons
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Post Content block used an incorrect icon, "alignjustify", and the justify icon was not in the new style.
This PR fixes both. It creates a new post content icon, and it updates the align justify icon, and it points the two blocks that used the post content icon to use the new icon.
Post content before:
After:
Here it is on the grid:
Technically the new justify icon isn't used at all now, because there aren't any visible tools to justify text for paragraphs. However as part of global styles, it might become an option, so I kept it in:
Checklist: