List View: Visual and design improvements #29769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Feature] List View
jasmussen
requested review from
ajitbohra,
chrisvanpatten and
ellatrix
as code owners
|
Size Change: +1.04 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Tests well for me. One small thought: Currently the indentation is multiples of 24px, and space between icon and label is 6px. If we increase those values to 28px and 8px respectively we see slightly improved visual alignment:
Obviously the trade-off is the additional 6px of horizontal space consumed. Edit: Added the Needs Figma Update label as I don't think we have this component in the library. |
jameskoster
added
the
Needs Figma Update
|
Excellent point, thank you. It's a bit trickier than just perfect metrics, though, because the icon does not fill out the full 24px space, so we actually have to optically hint a little bit. Here's the structure before I made any changes, which is a pure 24px indentation:
Note the orange margin here, it's 6px, or half of the 12px grid.
Here's what happens if we change that to 24px + 6px:
Now the icon footprint aligns perfectly to the text above. But the icon inside does not, it's indented. The change I pushed, changes the indentation to 24px + 4px, i.e. 2px less than the text is indented:
When pushing the change, it seemed better. But looking now, I'm not actually sure 🙈 Here's a version where the indentation is 24px + 2px:
That last change I think looks better, but I haven't pushed it. What do you think? |
|
24 + 2 looks too cramped to my eye:
28 + 8 or 24 + 4 feel like a sweet spot to me, the visual alignment seems good, and all values align to a 4px grid:
|
|
Cool, 4 is what I pushed. |
jameskoster
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Figma component added https://www.figma.com/file/e4tLacmlPuZV47l7901FEs/WordPress-Design-Library?node-id=9490%3A85.
jameskoster
removed
the
Needs Figma Update
|
Thanks so much for the review. Because this one affects all modals, even if tested well, I'm going to let it sit for the weekend to gather additional sanity checks. I don't see how anything should be negatively affected, but still, now there's the weekend! |
|
I gave the modals a spin:
The change to modals is small. The extra horizontal padding is necessary for aligning the text with the items. I think it's worth it. But it's also so trivial to change back that if it causes issues, I'll happily follow up. |
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #26141 and #29727, a few tiny design refinements are shown that affect the modal dialog, and items in the list view. Specifically:
This PR addresses all of those, so that #26141 can be about adding the folding chevrons alone, and #29727 can be about adding the drag handle and graduating the drag and drop behavior.
How has this been tested?
Please test every screen that leverages the list view, including the Site editor with the persistent list view, the post editor block navigation, and the modal list view from the Navigation block:
Observe the new design is applied across, but with no regressions.
Specifically please test also modal dialogs such as keyboard shortcuts or block manager, to see that the tweaked margin works well.
Checklist: