Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph blocks don't have focus when added #29259

Closed
kevin940726 opened this issue Feb 23, 2021 · 4 comments
Closed

Paragraph blocks don't have focus when added #29259

kevin940726 opened this issue Feb 23, 2021 · 4 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@kevin940726
Copy link
Member

Description

Not sure since when, adding a paragraph block no longer moves the focus to the input itself, but rather a "parent"-ish block wrapper. Pressing Enter can no longer continue the writing experience either. See the below screencast for more info.

I haven't bisected the exact commit that causes this issue, but this feels unintentional and seems like a regression to me. It might be related to some focus-related work being done recently like #28191 and #28962. Pinging @youknowriad here for more insights 😉 .

Step-by-step reproduction instructions

  1. Go to the post editor by adding a new post
  2. Add the first paragraph
  3. Hit Enter to start a new paragraph
  4. Type something and observe that the focus is not within the input hence no characters are being typed to the screen.

Expected behaviour

Should be able to add/edit content more smoothly.

Actual behaviour

The writing flow is blocked by unfocused inputs.

Screenshots or screen recording (optional)

Kapture.2021-02-23.at.18.40.55.mp4

WordPress information

  • WordPress version: trunk
  • Gutenberg version: master
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: Desktop
  • Operating system: macOS
  • Browser: Chrome
@kevin940726 kevin940726 added the [Type] Bug An existing feature does not function as intended label Feb 23, 2021
@youknowriad
Copy link
Contributor

I'm pretty sure we have e2e tests for this that would have caught it. Could you have another thing that could impact this.

@kevin940726
Copy link
Member Author

kevin940726 commented Feb 23, 2021

Nothing that I'm aware of, no 🤔.

@stokesman
Copy link
Contributor

I'm not seeing this either. One time, when I was seeing what I thought was a regression, it resolved when I restarted npm run dev (which clears the build directories).

@kevin940726
Copy link
Member Author

Seems like this has already been fixed by #29279, closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants