Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo level present on load #2916

Closed
ellatrix opened this issue Oct 7, 2017 · 1 comment · Fixed by #3178
Closed

Undo level present on load #2916

ellatrix opened this issue Oct 7, 2017 · 1 comment · Fixed by #3178
Labels
[Type] Bug An existing feature does not function as intended

Comments

@ellatrix
Copy link
Member

ellatrix commented Oct 7, 2017

Issue Overview

When the editor finished loading, an undo level is already present, even though there's nothing to undo yet.

@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Oct 7, 2017
@aduth
Copy link
Member

aduth commented Oct 9, 2017

Related to #2915 (comment), this is partly related to the reason for reset actions, which is that since undo history is tracked for any action causing a change in the undoable reducer value, we need to make sure that initialization actions occurring on page load are not reflected as changed through Undo, either by avoiding changes in state, or assigning the clean state point via an action ("RESET_POST").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants