Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a template: List template parts consumed, and provide access to edit them in isolation #29147

Closed
jameskoster opened this issue Feb 19, 2021 · 5 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts

Comments

@jameskoster
Copy link
Contributor

While editing a template it could be handy to have quick access to a list of consumed template parts, along with links to edit them in a focussed view.

Some areas we might consider exposing this list and/or access to a focussed edit view:

  • Template information popover in top bar
  • "Template" tab in the Inspector
  • The ellipsis menu in the toolbar when a template part is selected
  • The Preview/View menu in the top bar
@jameskoster jameskoster added Needs Design Needs design efforts. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 19, 2021
@jameskoster
Copy link
Contributor Author

Here's a concept that explores the ideas outlined in the OP:

areas.mp4

I think that listing the template parts in the "Template" tab of the Inspector, and the template details popover work well. The "View" menu... not so much.

Using this UI to select the template part aligns nicely with the parent block selection flow:

select-parent

Isolated edit mode can be accessed through the ellipsis menu on the block tool bar, once the template part has been selected. That will be explored in more detail in #29148.

@noisysocks
Copy link
Member

Is it possible too have nested template parts? If so, should we display a list of consumed template parts in the isolated template part editor's dropdown as well?

@mtias
Copy link
Member

mtias commented Sep 8, 2021

It's possible but we should not do anything extra to accommodate it — the user would be able to select the nested part and focus on it if necessary, like using the list view panel for example.

@kevin940726
Copy link
Member

All of the above except for the Preview/View menu have been implemented. Have we decided to implement it in Preview/View yet? It seems a little bit weird to me to have template areas in that menu. Just doesn't feel like it belongs there.

@jameskoster
Copy link
Contributor Author

Nice work! We can leave the View menu for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

4 participants