Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive blocks: Map, Contact Form, Audio, Playlist #283

Closed
jasmussen opened this issue Mar 16, 2017 · 7 comments · May be fixed by wpscholar/gutenberg#2
Closed

Interactive blocks: Map, Contact Form, Audio, Playlist #283

jasmussen opened this issue Mar 16, 2017 · 7 comments · May be fixed by wpscholar/gutenberg#2
Labels
[Feature] Blocks Overall functionality of blocks

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Mar 16, 2017

Here are a stack of new blocks that depict slightly more complex blocks. Working on these blocks raised a few questions that @j-falk also raised in Slack: where does configuration happen? While we have many ideas, there's no place like mockups to hash them out, so here goes.

Map

Empty:

map empty

Empty, Hover:

map empty hover

Neutral:

map neutral

Hover:

map hover

Selected:

map selected

Caption:

map caption


Contact Form

Neutral:

contact form

Hover:

contact form hover

Selected:

contact form selected


Audio Shortcode

Empty:

audio empty neutral

Empty, Hover:

audio empty hover

Neutral:

audio neutral

Hover:

audio hover

Selected:

audio selected

Caption:

audio caption


Playlist Shortcode

Empty:

playlist empty

Empty, Hover:

playlist empty hover

Neutral:

playlist neutral

Hover:

playlist hover

Selected:

playlist selected

Caption:

playlist caption


Questions

Some issues arise that need discussing:

  • What do we do with the type switcher when the block can't be converted into something else, or there isn't yet any compatible block types installed via plugins? Do we still show it as a type indicator?
  • It is tempting, like on the Playlist, to show a "Edit Contact Form" button on the block placeholder itself, to open the modal where editing the form will likely happen. Is that a better UI than the edit button on the toolbar?
@youknowriad
Copy link
Contributor

youknowriad commented Mar 16, 2017

Do you think showing a "preview" of the Contact Form is worth it? I mean, can't we just show the form for adding/editing the fields instead (to avoid having to click on a button to open a modal or something)?

Btw, great work as always @jasmussen

@jasmussen
Copy link
Contributor Author

Do you think showing a "preview" of the Contact Form is worth it?

Not sure. The contact form is probably not going to be a core block, and so it's more of a "this is what a plugin could add" concept block. It's tricky because should the form be enabled or disabled in this view? How do you select "just the block" (same problem as with an embedded YouTube video, how do you select it without pressing play).

On the flipside to this argument, perhaps the form is disabled until you click into the block. Then it becomes editable right there. I like that.

@joyously
Copy link

To avoid "using" the block while editing, perhaps these types of blocks should stay in the mode of data entry, and the control block could have a Preview button. This would help in verifying the inputs, such as comparing two videos that look similar, and selecting and moving the block.

@inhll
Copy link

inhll commented Mar 21, 2017

It is tempting, like on the Playlist, to show a "Edit Contact Form" button on the block placeholder itself, to open the modal where editing the form will likely happen. Is that a better UI than the edit button on the toolbar?

I would say the edit button remaining on the toolbar is the best option. Clicking the edit button could pop up a modal to allow form editing in a context that is clearer than having to remove and re-add the block.

map

@jasmussen jasmussen added this to the Alpha milestone Apr 20, 2017
@jasmussen jasmussen added the [Feature] Blocks Overall functionality of blocks label May 10, 2017
@mtias mtias removed this from the May Week 3 (Alpha) milestone May 16, 2017
@mtias
Copy link
Member

mtias commented May 16, 2017

Let's create individual issues so we can assign them.

@jasmussen
Copy link
Contributor Author

Let's create individual issues so we can assign them.

On it.

This was referenced May 16, 2017
@jasmussen
Copy link
Contributor Author

Closing in favor of #803, #804, #805. Contact Form was always meant to be an example of how a plugin could add such a block, not an effort we should pursue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants