Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-site Editing: Themes located in a subdirectory do not load template parts #28022

Closed
kjellr opened this issue Jan 6, 2021 · 4 comments
Closed
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Jan 6, 2021

If a theme is loaded from a subdirectory, then its template parts are not properly loaded into the site editor. For example, if the theme is located here:

wp-content/themes/subfolder/themename

instead of:

wp-content/themes/themename

This has come up when folks test the TT1 Blocks theme: it used to work when you copied the entire theme-experiments folder into wp-content/themes, but it no longer does. This was fixed once before in #26391.

I believe this will be fixed by #27765, but opening an issue here to track the bug.

@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing labels Jan 6, 2021
@jffng
Copy link
Contributor

jffng commented Jan 19, 2021

Is this fixed by #28088?

@jeyip
Copy link
Contributor

jeyip commented Jan 20, 2021

Is this fixed by #28088?

Almost! We need to update block themes before the issue is completely resolved. I've modified seedlet blocks here and block theme experiments here.

There's a note in the PR description for #28088 with more information, but in essence, the problem isn't fixed until we remove theme attributes from theme provided block templates.

@annezazu
Copy link
Contributor

annezazu commented Apr 6, 2021

Just noting that @helen ran into this today while streaming resulting in a really jarring experience especially when trying to use the Live Preview option for block themes. When this is fixed, should confirm it works with the Live Preview option under Appearance > Themes.

@carolinan
Copy link
Contributor

Template parts for themes inside subfolders are working so I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants