-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editing: Contextual template part icon and name #27876
Comments
How are we distinguishing between generic template parts and header/footer/sidebar? Should we just check for template part name? Something like "if template part name contains 'header" then use "template part header" icon. |
Good question, I suppose #27337 is a blocker to this being fully implemented. |
We should define canonical template parts types that core supports. It will then be possible to assign these types to template parts and customize some parts of the experience accordingly (e.g. filtering patterns, showing contextual icons etc.).
Yes. |
It seems this is wrapped now. We'll have a separate issue to explore the colors. |
With #27378 merged, we should update any component that displays the template part name + icon.
Icons
layout
icon.templatePartHeader
icontemplatePartFooter
icontemplatePartSidebar
iconName
If the selected template part has a name, we should display that instead of the generic "Template Part" label. So if I select the "Header" template part, I should see "Header" as the block name in the Inspector, along with the appropriate icon and colorisation.
Off the top of my head, the only other location we'll need to update this is the block navigator. If the inserter / quick inserter exposes specific template parts we'll need to update that as well.
Examples:
The text was updated successfully, but these errors were encountered: