Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Add in ability open link in new window #2674

Closed
munirkamal opened this issue Sep 5, 2017 · 3 comments
Closed

Button: Add in ability open link in new window #2674

munirkamal opened this issue Sep 5, 2017 · 3 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@munirkamal
Copy link
Contributor

So now as we got the ability to set the link to open in new window for text links, how about adding same option for Button block as well.

@karmatosed
Copy link
Member

I think that would be a good idea +1

@karmatosed karmatosed added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. labels Sep 5, 2017
@munirkamal
Copy link
Contributor Author

@karmatosed

Cool, just like to add further it should be consistent throughout all blocks where link icon appears like image Block also has the link icon. Shouldn't that also allow to set the link to open in new window?

@danielbachhuber
Copy link
Member

Closing in favor of #4597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants