Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When widget form is empty the Legacy Widget "Preview" doesn't have enough info to display anything #26473

Closed
mapk opened this issue Oct 26, 2020 · 3 comments
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@mapk
Copy link
Contributor

mapk commented Oct 26, 2020

Problem

Many 3rd party widgets require a form to be filled out before the widget can output anything. But the Legacy Widget block offers a "Preview" button even if nothing is filled out. Clicking this "Preview" button just shows an empty preview. This doesn't help explain to the user what needs to be done.

Example of problem
blank-preview

Solution

We could try a couple different things here.

  1. Disable the "Preview" option until there is enough information filled out to display something.
  2. Provide some messaging in the Preview that tells the user that it requires more info before displaying anything.
@mapk mapk added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets labels Oct 26, 2020
@paaljoachim
Copy link
Contributor

Hey Mark. @mapk

Good idea!
The "Preview" button can initially be disabled. Greyed out perhaps when there is nothing to preview. When the user adds something the button stops being greyed out giving the signal to the user that there is now some content that can be previewed.

@shaunandrews
Copy link
Contributor

I touched on the "empty widget" issue in this comment: #26179 (comment)

Basically, I think an "empty" widget should just default to always showing its editing UI until any requirements are met to display a widget. In the scenario where there would never be a widget (is this a real scenario?) then it would always display the editing UI.

@draganescu
Copy link
Contributor

I think #26179 (comment) closes this by solving it in the proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants