Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widgets Screen] Drag & dropping legacy text widget sometimes causes breakage #26236

Closed
annezazu opened this issue Oct 17, 2020 · 5 comments
Closed
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Describe the bug

When dragging & dropping the text legacy widget into a new widget area, the text area disappears.

To reproduce
Steps to reproduce the behavior:

  1. Go to Appearance > Widgets and add at least one text widget with some text.
  2. Install and activate Gutenberg.
  3. Head to Appearance > Widgets
  4. Drag the legacy text widget into a new widget area.
  5. See that the editor section is gone.

Expected behavior

I expect to still be able to still see the editor for the body of the text widget.

Screenshots

Here's a 1 min video: https://cloudup.com/cRK4CZJGQn3

Here's what it looks like after dragging and dropping:

Screen Shot 2020-10-16 at 9 07 29 PM

Editor version (please complete the following information):

  • WordPress version: 5.5.1
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? Gutenberg Plugin
  • If the Gutenberg plugin is installed, which version is it? 9.1.1

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 86.0.4240.75
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets labels Oct 17, 2020
@draganescu
Copy link
Contributor

I can confirm this.

@noisysocks
Copy link
Member

When I test this I'm not able to drag and drop anything into a new widget area.

@talldan
Copy link
Contributor

talldan commented Apr 27, 2021

I couldn't reproduce the issues mentioned.

When dragging into an empty widget area, I'm seeing that the blue insertion point line doesn't appear. But dropping in the right place (when the cursor has the + symbol) still works.

What's everyone else seeing?

@noisysocks
Copy link
Member

noisysocks commented Apr 28, 2021

Aha I see. The problem I noticed is that you cannot seem to drag and drop into an empty widget area.

Edit: Sorry, it does work! It's just that without the blue line it's really hard to tell where you need to release the mouse.

@tellthemachines
Copy link
Contributor

I could repro this up to 10.4.1, but can no longer with 10.5 or with the latest trunk. Let's close it as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants