Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: Close the source selection dropdown once image is replaced #25722

Closed
alaczek opened this issue Sep 30, 2020 · 1 comment
Closed
Labels
[Feature] Media Anything that impacts the experience of managing media [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@alaczek
Copy link

alaczek commented Sep 30, 2020

When using the "Replace" function of the Image block, after a different image is selected and the media modal is closed, the media source selection dropdown remains open, partially obscuring the image. This is a minor thing, but I found it quite annoying after a while, so I thought I'd report and see if this is something that could be changed.

For comparison, when using one of the text formatting options of the Paragarpah block, for example, uppercase, the dropdown disappears as soon as an option is selected.

Here's a quick video of the issue:
https://cloudup.com/cFXviPSIYEW

@talldan talldan added [a11y] Keyboard & Focus [Feature] Media Anything that impacts the experience of managing media Needs Accessibility Feedback Need input from accessibility and removed Needs Accessibility Feedback Need input from accessibility labels Sep 30, 2020
@talldan
Copy link
Contributor

talldan commented Sep 30, 2020

@alaczek My understanding is that this is on purpose. When the media modal is closed using the keyboard, focus is returned to the 'Open Media Library' button. If the button were no longer visible there could be a focus loss issue, or focus would be returned to an unexpected place. There's an issue here from the accessibility audit that provides more background on why menus and modals behave this way - #15321.

The formatting issue might be a bug. I'm sure I recall a ticket for this, but I can't find it now.

@talldan talldan closed this as completed Sep 30, 2020
@priethor priethor added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

3 participants