Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need add "open in new tab" feature in social share in Gutenberg #25455

Closed
Preciousomonze opened this issue Sep 18, 2020 · 2 comments · Fixed by #25468
Closed

Need add "open in new tab" feature in social share in Gutenberg #25455

Preciousomonze opened this issue Sep 18, 2020 · 2 comments · Fixed by #25468
Assignees
@fabiankaegy
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@Preciousomonze
Copy link

@rkradadiya noticed in the social share widget there is no option for the "open in new tab" feature.
This has already been reported on trac , as ticket 51250
🙂
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Sep 18, 2020
@fabiankaegy
Copy link
Member

I can take this one and work on a PR.

@fabiankaegy fabiankaegy self-assigned this Sep 18, 2020
@fabiankaegy fabiankaegy mentioned this issue Sep 18, 2020
Merged
5 tasks
@fabiankaegy fabiankaegy linked a pull request Sep 18, 2020 that will close this issue
Add "open in new tab" feature to Social Links Block #25468
Merged
5 tasks
@mkaz
Copy link
Member

mkaz commented Sep 18, 2020

Duplicate of #20707

@mkaz mkaz marked this as a duplicate of #20707 Sep 18, 2020
@mkaz mkaz closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabiankaegy fabiankaegy

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "open in new tab" feature to Social Links Block WordPress/gutenberg
4 participants
@mkaz @afercia @Preciousomonze @fabiankaegy