Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link color doesn't work for author role #25151

Closed
oandregal opened this issue Sep 8, 2020 · 4 comments
Closed

Link color doesn't work for author role #25151

oandregal opened this issue Sep 8, 2020 · 4 comments
Assignees
@jorgefilipecosta
Labels
[Type] Bug An existing feature does not function as intended

Comments

@oandregal
Copy link
Member

How to test:

  • Install the Seedlet theme, or any other theme that has support for the link color feature.
  • As an author role, go to the post editor and add a paragraph with a link.
  • Change the link color via the block settings.
  • Publish post.

The expected result is that the paragraph, in the front-end, has the class has-link-color and also has inlined the style for the color such as style="--wp--style--color--link:<some-color-here>". What happens instead is that the CSS custom property isn't present.
@oandregal
Copy link
Member Author

This probably needs checking against the unfiltered_html capability as different setups may have different role-capabilities mappings.

@oandregal oandregal added the [Type] Bug An existing feature does not function as intended label Sep 8, 2020
@oandregal oandregal mentioned this issue Sep 8, 2020
Closed
@mcsf
Copy link
Contributor

mcsf commented Sep 8, 2020

Whatever the fix, I recommend adding an E2E test, however small. That way it's guaranteed to be tested by CI against both admin and author roles.

@oandregal oandregal mentioned this issue Sep 17, 2020
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 17, 2020
@oandregal oandregal removed the [Status] In Progress Tracking issues with work in progress label Oct 10, 2020
@oandregal oandregal removed their assignment Oct 10, 2020
@oandregal oandregal mentioned this issue Nov 11, 2020
Closed
82 tasks
@oandregal oandregal mentioned this issue Jan 12, 2021
Merged
@oandregal oandregal mentioned this issue May 5, 2021
Closed
@oandregal
Copy link
Member Author

oandregal commented May 5, 2021 •
edited
Loading

Related #31488 (will be fixed if/when that approach lands)

@oandregal
Copy link
Member Author

This has been fixed by landing #31524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgefilipecosta jorgefilipecosta

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix link color for roles without unfiltered_html capabilities WordPress/gutenberg
3 participants
@mcsf @oandregal @jorgefilipecosta