Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard in select mode: Show available moves #25126

Open
mariohamann opened this issue Sep 7, 2020 · 9 comments
Open

Keyboard in select mode: Show available moves #25126

mariohamann opened this issue Sep 7, 2020 · 9 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback.

Comments

@mariohamann
Copy link

Problem

I was interested in using the keyboard in select mode and felt a bit lost sometimes.

Solution

I would be happy to see the currently usable moves in the snackbar. Especially for nested blocks this might be very helpful.
select snackbar

Alternatives

Not really alternatives but here are some thoughts on the design:

Arrow design

I think the first version is the best compromise between readability and providing idea to press a key. In terms of readability and a11y, the last version might be better. The outlined version does not match to the inverted coloring.
image

Opacity of disabled moves

I tried 45%, 30% and 15%. For me 30% seems to be the best compromise.
image

Additional spacing

It would be a nice improvement to bundle related functions with a small spacer.
image

@mariohamann
Copy link
Author

mariohamann commented Sep 8, 2020

A few hours later I'm asking myself if this feature might be too focused on keyboard users. Furthermore I realized that one target group of keyboard mode are the visually impaired, and that they of all people cannot really profit from it. Therefore, maybe it should be an (a) optional setting or (b) the snackbar should only appear after pressing the first arrow key (→ means: "keyboard mode finally activated").

@mariohamann
Copy link
Author

mariohamann commented Sep 8, 2020

Alternative

While creating an issue to show outlines of blocks in select mode (#25133), I had another idea: Instead of using the snackbar, the available momements/keys could be shown directly at the blocks.

select adaptive

Designs I tried

1

The first one uses the "block name rectangle" – but it causes a lot of overlapping and maybe it's not easy enough to identify them.

select snackbar 001

2

The second one is the one I used for the GIF. Better, but maybe too large AND too low contrast.

select snackbar 002

3

The third one might be the most appealing. It's a bit smaller and therefore causes less overlapping and has a higher contrast, going well with the "add"-button. BUT it could be identified as clickable button e. g. to move a block.

select snackbar 003

@mariohamann mariohamann changed the title Keyboard in select mode: Show snackbar with available moves Keyboard in select mode: Show available moves Sep 8, 2020
@annezazu annezazu added [a11y] Keyboard & Focus [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. labels Sep 15, 2020
@annezazu
Copy link
Contributor

Thanks so much for this thorough and in depth report, @mariohamann! I've added appropriate labels so more people can chime in.

@afercia
Copy link
Contributor

afercia commented Sep 24, 2020

Interesting idea thanks @mariohamann. I'd totally agree there's the need to better communicate how to navigate with keyboard especially with some layouts e.g.: Columns block, groups, nested blocks. In these cases users really have to guess when they're supposed to use the Tab key (to move through blocks at the same level) or the arrow keys (to move deeper into nested levels). There's room for improvements here as the UI doesn't communicate the available actions at all.

As you also pointed out, not sure the "snackbars" would be an appropriate place to show this info, as snackbars aren't accessible to start with.

Showing the available actions within the block itself sounds better, as that's the place where users focus is. However, the squares with arrows I see in the mockups above would be only a visual information. How to communicate these infos to screen reader users?

@mariohamann
Copy link
Author

mariohamann commented Sep 24, 2020

How to communicate these infos to screen reader users?

Maybe pressing ?or similiar (is there a common key for actions like this?) could inform screen reader users which possibilities are available?

@afercia
Copy link
Contributor

afercia commented Sep 24, 2020

One thing is a general information on keyboard keys / shortcuts to use.
Another thing is contextual information while using the blocks, as in this case 🙂 The displayed squares with arrows are contextual, meaning that they show the right information at the right moment. There should be an equivalent information for screen readers users as well.

@mariohamann
Copy link
Author

mariohamann commented Sep 24, 2020

That's what I tried to describe. Example: A block is focused, screen reader user presses ? and Screen reader says:

"Left: Next Column
Up: Group above
Down: First block in column"

@afercia
Copy link
Contributor

afercia commented Sep 24, 2020

And why users should have a clue they have to press ? to get some information that is not expected to be there? 🙂

@hedgefield
Copy link

This is a really nice idea, and I agree that placing the indicators in the content is the best way to contextualize the movement direction.

I have to admit that I'm not yet very familiar with keyboard navigation in Select mode. Is this intended to show where the selection focus will move when pressing certain buttons, or to indicate where a selected block will move to when you press an arrow key? Could you describe the scenario briefly for us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

5 participants