Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Library: Move translatable fields to block.json files for core blocks #23792

Closed
gziolo opened this issue Jul 8, 2020 · 0 comments · Fixed by #31120
Closed

Block Library: Move translatable fields to block.json files for core blocks #23792

gziolo opened this issue Jul 8, 2020 · 0 comments · Fixed by #31120
Assignees
@gziolo
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress

Comments

@gziolo
Copy link
Member

gziolo commented Jul 8, 2020 •
edited
Loading

Part of #16209.

Depends on #23636 – i18n support to block.json metadata file is missing at the moment.

Move translatable fields (title, description, keywords, styles.label) to block.json for all core blocks.

Done

In addition to that, wp_set_script_translations call should be added to ensure that translations are loaded for the script (similar to what was added in #24125). See:

https://github.com/WordPress/wordpress-develop/blob/e4bda140d4437f5bd5690e18bc12a0eb70bb92c9/src/wp-includes/blocks.php#L137-L139
@gziolo gziolo added Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Block library /packages/block-library labels Jul 8, 2020
@gziolo gziolo mentioned this issue Jul 8, 2020
Closed
14 tasks
@gziolo gziolo mentioned this issue Apr 23, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gziolo gziolo

Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block Library: Move translatable fields to block.json files WordPress/gutenberg
1 participant
@gziolo