-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the SEO settings block from the nav block #23153
Comments
Isn't |
Couple of remarks:
|
Didn't know that, thanks! |
I dug into why this attribute was added and found #13690 (comment). We need to support setting the It's also worth noting that the Buttons block supports setting the Instead of removing the SEO settings panel, let's replace it with the same Link settings panel that the Buttons block has. |
Great idea! See the updated version of #23682 I wonder if some description there would be useful to explain what that field even is, probably an external link would be needed because of the volume of information - thoughts? |
Describe the bug
I was testing the Nav block and saw the SEO settings block:
I think it's problematic to add this to core. The wording is already wrong (as this is a hint and not a "rule", like
robots.txt
is) and it links to a Codex page that is outdated.We've seen over the past few months that different SEO plugins chose to word these options differently, because of a difference of opinion in how this should work and also a difference in how they perceive their audience.
Also, the large majority of WordPress users should not use this toggle, like, ever. Which makes it risky to add this.
I strongly feel therefor that this should be plugin territory and should not be dealt with in core. If we do decide to ship this in core, the wording should be changed, the linked-to page should be updated and it should still become filterable.
To reproduce
Steps to reproduce the behavior:
Expected behavior
Don't have a default SEO settings block, allow plugins to filter and add a block like this themselves.
Editor version (please complete the following information):
The text was updated successfully, but these errors were encountered: