Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin needs menu option to add New Page #2239

Closed
maddisondesigns opened this issue Aug 5, 2017 · 8 comments
Closed

Plugin needs menu option to add New Page #2239

maddisondesigns opened this issue Aug 5, 2017 · 8 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@maddisondesigns
Copy link

Issue Overview

At the moment, the Gutenberg plugin provides the option to add a New Post. It doesn't provide the option to add a New Page though, even though you can edit a page in Gutenberg.

Expected Behavior

I should be able to add a new Page.

Current Behavior

I have to add a new Page using the existing Pages > Add New menu option. I then have to save as draft, browse browse back to the Dashboard and then re-edit the page using Gutenberg.

Possible Solution

Simply add a New Page option to the Gutenberg menu.

Plugin Version 0.7.1

@karmatosed karmatosed added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Sep 24, 2017
@karmatosed karmatosed added this to the Beta 1.3 milestone Sep 24, 2017
@karmatosed
Copy link
Member

I agree being explicit and adding 'new page' could be good for users.

@grantpalin
Copy link

I'd like to take this one on.

@karmatosed
Copy link
Member

That's great @grantpalin, look forward to your pull request!

@grantpalin
Copy link

grantpalin commented Oct 3, 2017

Added a PR. A couple of issues I have with it:

  • Both subitems are bolded when one is active:
    image
    I suspect that I need to distinguish the menu-slug attribute on the add_submenu_page calls, but trying that yields:
    image
    And in both cases the entry is saved as a post.
  • Ensuring that Gutenberg knows it is doing a page and not a post - haven't yet found out how

@mtias mtias modified the milestones: Beta 1.4, Beta 1.5 Oct 10, 2017
@amarpathak
Copy link

amarpathak commented Oct 16, 2017

I am New to Open Source Contribution world, can I contribute on this issue ?
I'd Like to take this issue. @mtias

@pento pento removed this from the Beta 1.5 milestone Oct 18, 2017
@pento
Copy link
Member

pento commented Oct 18, 2017

With bdf94e6 landing, we don't need this menu item anymore.

@pento pento closed this as completed Oct 18, 2017
@maddisondesigns
Copy link
Author

@pento Is this forcing Gutenberg to be the default editor when you click the Add New button on the Posts and Page screens? I really hope that's not the case. The Gutenberg plugin shouldn't be making itself the default editor. It's a plugin for a reason and shouldn't be changing the default editing experience. If this is the case, is there a Github issue you can link to that is discussing this?

@grantpalin
Copy link

@maddisondesigns Discussed on #2824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

No branches or pull requests

6 participants