Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core themes compatibility with simplified Button block markup #21909

Closed
andrewserong opened this issue Apr 27, 2020 · 1 comment · Fixed by #21923
Closed

Core themes compatibility with simplified Button block markup #21909

andrewserong opened this issue Apr 27, 2020 · 1 comment · Fixed by #21923

Comments

@andrewserong
Copy link
Contributor

andrewserong commented Apr 27, 2020

The simplified Button markup introduced in #21266 appears to require updates in the core themes so that the new buttons match the legacy button styling. In the following themes, if you add some new buttons (select a mix with outline styles), their styling doesn't match how the theme handles legacy buttons. After the fixes in #21642 and #21816, the legacy buttons are looking pretty good! Looks like it's now the new markup that needs addressing.

Some of the button styles below are closer than others (e.g. the difference might only be a lack of uppercase or underline, but for others like 2019, the difference is more pronounced). Note that in each of the screenshots under "New buttons", two of the buttons should be rendered with outline styles.

Twenty Nineteen

Legacy buttons New buttons
image image

Twenty Seventeen

Legacy buttons New buttons
image image

Twenty Sixteen

Legacy buttons New buttons
image image

Twenty Fifteen

Legacy buttons New buttons
image image

Twenty Fourteen

Legacy buttons New buttons
image image

Twenty Thirteen

Legacy buttons New buttons
image image

Twenty Twelve

Legacy buttons New buttons
image image

Twenty Eleven

Legacy buttons New buttons
image image

I haven't included themes 2010 and 2020 in this list because they're looking pretty good to me so far.

Is this the best place to log this issue for these themes, or should individual tickets be opened separately? (I wasn't sure if there might be individual tracking issues already)

CC: @youknowriad

@youknowriad
Copy link
Contributor

youknowriad commented Apr 27, 2020

Thanks for checking these themes, this is very helpful and I'm personally glad the breakage look minor in general.

I'm not sure about whether we should have individual issues or tickets but it's definitely better to move this issue to Core Trac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants