Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button blocks using outline style in old markup render incorrectly #21747

Closed
andrewserong opened this issue Apr 21, 2020 · 0 comments · Fixed by #21816
Closed

Button blocks using outline style in old markup render incorrectly #21747

andrewserong opened this issue Apr 21, 2020 · 0 comments · Fixed by #21816
Assignees
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Block] Buttons Affects the Buttons Block Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress

Comments

@andrewserong
Copy link
Contributor

The fix for Buttons using old button markup worked for me in testing normal buttons, but buttons with an Outline style are currently rendering with an additional border / displaying in unexpected ways.

To reproduce
Steps to reproduce the behavior:

  1. In WordPress 5.4 create a Buttons block and add in a few buttons using the Outline style
  2. Also, add in the following (legacy) Button markup to a post/page:
<!-- wp:button {"textColor":"background","className":"is-style-outline"} -->
<div class="wp-block-button is-style-outline"><a class="wp-block-button__link has-text-color has-background-color" href="/contact">Get in touch</a></div>
<!-- /wp:button -->
  1. Publish the post and ensure that the buttons render correctly with their outline styles
  2. Install / update Gutenberg plugin to 7.9.1
  3. View the post/page, the button container is rendered with an outline

Expected behavior
The legacy existing markup to continue to render Button blocks with outlines in a backwards compatible way.

Screenshots
I tested this out in a few different themes available in .org, here are screenshots from a couple of themes listed as Popular:

Hestia

image

Lorina

image

2019

image

Editor version (please complete the following information):

  • WordPress version: 5.4
  • Gutenberg plugin: 7.9.1

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 81

Additional context

CC: @youknowriad @alshakero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Block] Buttons Affects the Buttons Block Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants