Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't save a reusable block until the user adds a name #21259

Closed
mtias opened this issue Mar 30, 2020 · 2 comments
Closed

Don't save a reusable block until the user adds a name #21259

mtias opened this issue Mar 30, 2020 · 2 comments
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Mar 30, 2020

At the moment, when creating a reusable block, we save an entry on the post type immediately. We should require the user to enter a name first. Saving immediately also has the issue that if you start typing and the async update happens a brief moment later, it removes the text you typed.
@mtias mtias added [Type] Enhancement A suggestion for improvement. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels Mar 30, 2020
@youknowriad
Copy link
Contributor

It seems like this might be a duplicate of #12940

@youknowriad
Copy link
Contributor

closing as duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@youknowriad @mtias