Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Expand JavaScript coding standards #2017

Closed
jasmussen opened this issue Jul 26, 2017 · 1 comment
Closed

Discussion: Expand JavaScript coding standards #2017

jasmussen opened this issue Jul 26, 2017 · 1 comment
Labels
[Type] Developer Documentation Documentation for developers [Type] Question Questions about the design or development of the editor.

Comments

@jasmussen
Copy link
Contributor

There's been talk about how Gutenberg is following the WordPress coding standards (https://codex.wordpress.org/WordPress_Coding_Standards), and how we are slowly adding to those standards with the new toolchain used for building Gutenberg.

It would be good to discuss and perhaps document what additions and/or changes we are making to the coding standards, so that these can be proposed for being added to the official guidelines. For example there's still some inconsistency in how deeply we nest SCSS classes, and how we label variables (http://getbem.com/introduction/). Some of those standards are from the Calypso standards: https://github.com/Automattic/wp-calypso/blob/master/docs/coding-guidelines/javascript.md

CC: @melchoyce as we discussed this.

@jasmussen jasmussen added [Type] Developer Documentation Documentation for developers [Type] Question Questions about the design or development of the editor. labels Jul 26, 2017
@mtias
Copy link
Member

mtias commented Aug 31, 2017

Going to close as this is not very actionable here, and is already part of broader discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

2 participants