Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Trash: hover and focus have difrerent colors #19841

Closed
afercia opened this issue Jan 23, 2020 · 0 comments · Fixed by #19974
Closed

Move to Trash: hover and focus have difrerent colors #19841

afercia opened this issue Jan 23, 2020 · 0 comments · Fixed by #19974
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jan 23, 2020

Describe the bug
The new "Move to Trash" button (styled like a link) uses different colors on :hover and :focus.

Previous implementation (WP 5.3.2):

Screenshot 2020-01-23 at 12 46 19

New implementation (WP trunk) with or without the Gutenberg plugin activated:

Normal state:

Screenshot 2020-01-23 at 12 46 37

Hover state:

Screenshot 2020-01-23 at 12 06 51

Focus state:

Screenshot 2020-01-23 at 12 07 01

Expected behavior
The button to use the same color change on :hover and :focus.

I'm not sure why on :hover it becomes blue in the first place. "Move to Trash" is a destructive action and should always use red.

WordPress has always used red for all the states of destructive action controls. For example, the legacy "Move to Trash" in the Classic Editor is always red: on :hover and :focus there's a slight change of the hue and brightness but it's still a red.

@afercia afercia added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
1 participant