Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max-height to CustomSelectControl menu #19751

Closed
Aljullu opened this issue Jan 19, 2020 · 0 comments · Fixed by #19753
Closed

Add max-height to CustomSelectControl menu #19751

Aljullu opened this issue Jan 19, 2020 · 0 comments · Fixed by #19753

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Jan 19, 2020

In WooCommerce Blocks we used the CustomSelectControl component to create a Country selector (see woocommerce/woocommerce-blocks#1585).

It had the issue that when all countries were displayed, the dropdown was taking the height of the entire screen. It could be easily fixed adding a max-height property to the menu, but probably we might want to do this upstream so all consumers of CustomSelectControl get this default max-height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant