Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Guide: modal should be labelled #19078

Closed
enriquesanchez opened this issue Dec 11, 2019 · 0 comments · Fixed by #19261
Closed

Welcome Guide: modal should be labelled #19078

enriquesanchez opened this issue Dec 11, 2019 · 0 comments · Fixed by #19261
Assignees
Labels
[Feature] NUX Anything that impacts the new user experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@enriquesanchez
Copy link
Contributor

Describe the bug
From #18041 (comment)

The modal is not labelled. This is in part a problem with this modal, but should probably be corrected in the component: the Modal component allows the component to be misused.

We should enforce a label for the modal element with role=dialog within the e2e tests, because all modals must be labelled. Additionally, the modal component should enforce role="document" on the content of all modal dialogs. This isn't strictly required on all modals, but the component can't know what type of content a modal will contain, this will give the best overall experience.

@enriquesanchez enriquesanchez added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] NUX Anything that impacts the new user experience labels Dec 11, 2019
@draganescu draganescu self-assigned this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] NUX Anything that impacts the new user experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants