Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submitting a link in the navigation block using the enter key causes a console warning. #19056

Closed
talldan opened this issue Dec 11, 2019 · 3 comments · Fixed by #19462 or #19651
Closed

Submitting a link in the navigation block using the enter key causes a console warning. #19056

talldan opened this issue Dec 11, 2019 · 3 comments · Fixed by #19462 or #19651
Assignees
@aduth
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Dec 11, 2019

Describe the bug
Submitting a navigation link causes the warning 'Form submission canceled because the form is not connected' to appear in the console.

To reproduce
Steps to reproduce the behavior:

  1. Add a navigation block
  2. Choose the 'Create empty' option on the placeholder
  3. Type in a URL and use the 'Enter' key to submit it.
  4. See error in the console

Expected behavior
The console error does not occur.
@talldan talldan added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Dec 11, 2019
@talldan talldan self-assigned this Dec 11, 2019
@talldan talldan mentioned this issue Dec 11, 2019
Merged
6 tasks
@aduth
Copy link
Member

aduth commented Dec 16, 2019

This is pretty disruptive for Travis builds. Should we revert #18933 in the interim?

@apeatling
Copy link
Contributor

@talldan Are you still looking at this one?

@talldan
Copy link
Contributor Author

talldan commented Jan 8, 2020

@aduth This PR resolved the issue for e2e tests for the moment:
https://github.com/WordPress/gutenberg/pull/19189/files#diff-b0caeafd8d509b35dbb33e19934e991bR138-R143

@apeatling yep, should have a PR up soon. I'll remove the above workaround for e2e tests in that PR.

@aduth aduth mentioned this issue Jan 9, 2020
Closed
@talldan talldan mentioned this issue Jan 10, 2020
Closed
6 tasks
@aduth aduth mentioned this issue Jan 13, 2020
Merged
@getdave getdave mentioned this issue Jan 14, 2020
Closed
@aduth aduth mentioned this issue Jan 14, 2020
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 14, 2020
@talldan talldan removed their assignment Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aduth aduth

Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
3 participants
@talldan @apeatling @aduth