Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline image: adjust high instead of width #18035

Open
burnuser opened this issue Oct 20, 2019 · 6 comments
Open

Inline image: adjust high instead of width #18035

burnuser opened this issue Oct 20, 2019 · 6 comments
Labels
[Block] Image Affects the Image Block [Block] Paragraph Affects the Paragraph Block Needs Design Needs design efforts. [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.

Comments

@burnuser
Copy link

Is your feature request related to a problem? Please describe.
When inserting an inline image (from block toolbar) the only possible adjustment is "Width", but the main adjustment task is to get the inserted image fitting the text high!

  • Bug: In WP 5.3 (nightly) The apply button covers the up/down size-change arrows

Describe the solution you'd like
1.) Replace adjustment of image "Width" with customizing the image "High"
2.) Add a Checkbox for automatic adaption to Text High
3.) Show image size changes immediately - at the moment it is trial an error (inserting a value =>hit Enter => check theresult => try it again with other value ...)

Describe alternatives you've considered

  • Enable floating option for Inline images: to use also bigger images within paragraphs and lists!
@swissspidy swissspidy added [Block] Image Affects the Image Block [Block] Paragraph Affects the Paragraph Block [Type] Enhancement A suggestion for improvement. labels Oct 22, 2019
@paaljoachim
Copy link
Contributor

Hi @burnuser

Thanks for creating this issue!
If I understand this correctly. You want to replace Width here with Height. Number 2 I am not certain about. 3 is covered as there is an Enter icon to update the image size.

Screen Shot 2021-01-18 at 20 41 56

Let me know how this works today for you.

@burnuser
Copy link
Author

Inline1

grafik

So:
1.) To get this result, adjusting the high of an inline image according to the known text high is much more useful than adjusting the width.
2.) "Checkbox for automatic adaption to text high" means an option to get the above result with computed image high instead of trial and error until the result looks OK.
3.) Yes, there is an Enter icon, which means "trail and error" with a lot of clicks:
try another size + hit Enter => try another size + hit Enter => try another size + hit Enter => ...
Compared to a regular image block with drag & drop size adjustment or immediate updating the visual size when changing the high and width values.

@paaljoachim
Copy link
Contributor

Hey @burnuser

Thank you for the additional information!
The Inline image feature is going to need a good update. I added the issue into an overview issue containing multiple Inline issues.

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 24, 2021

Hello again @burnuser
If you could have the user interface and options exactly like you want. What would it look like and which options would you want included? (No pressure. I am just asking for your ideas some quick sketching, features etc)
I ask because I am looking at creating a new UI for the Inline image feature.

@burnuser
Copy link
Author

OK, some wishes, ... dear Santa!

1.) Replace "Width" with "High"
2.) add a Button "Adjust to line high"
3.) Add alignment options
grafik
=> Enabling floating text around an image WITHIN a paragraph or list like in good old TinyMCE!
4.) Make the changes visible in real time like in regular images
5.) Enable Drag & Drop adjustment with handles like in regular images
grafik

@paaljoachim
Copy link
Contributor

Thank you @burnuser
I added the "Needs Design" label to it. At present time I am uncertain of how the user interface should look for the Inline image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Block] Paragraph Affects the Paragraph Block Needs Design Needs design efforts. [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants